Skip to content

fix(elasticsearch): Prevent mixing bulk and non-bulk operations #22803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pemontto wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(elasticsearch): Prevent mixing bulk and non-bulk operations #22803

pemontto wants to merge 1 commit into from
+2 −1

Conversation

@pemontto
Copy link
Contributor

@pemontto pemontto commented Dec 5, 2025

Summary

Move bulkOperation parameter retrieval outside the loop to enforce consistent bulk mode across all items. Previously, output order was not preserved when mixing bulk and non-bulk operations because non-bulk results were added immediately during the loop while bulk results were added later after the bulk API call.

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@pemontto
fix(elasticsearch): Prevent mixing bulk and non-bulk operations
6a5443c 
Move `bulkOperation` parameter retrieval outside the loop to enforce consistent bulk mode across all items. Previously, output order was not preserved when mixing bulk and non-bulk operations because non-bulk results were added immediately during the loop while bulk results were added later after the bulk API call.
cubic-dev-ai[bot]
cubic-dev-ai bot reviewed Dec 5, 2025
View reviewed changes
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request in linear Issue or PR has been created in Linear for internal review labels Dec 5, 2025
@n8n-assistant
Copy link

n8n-assistant bot commented Dec 5, 2025

Hey @pemontto,

Thank you for your contribution. We appreciate the time and effort you’ve taken to submit this pull request.

Before we can proceed, please ensure the following:
• Tests are included for any new functionality, logic changes or bug fixes.
• The PR aligns with our contribution guidelines.

Regarding new nodes:
We no longer accept new nodes directly into the core codebase. Instead, we encourage contributors to follow our Community Node Submission Guide to publish nodes independently.

If your node integrates with an AI service that you own or represent, please email [email protected] and we will be happy to discuss the best approach.

About review timelines:
This PR has been added to our internal tracker as "GHC-5793". While we plan to review it, we are currently unable to provide an exact timeframe. Our goal is to begin reviews within a month, but this may change depending on team priorities. We will reach out when the review begins.

Thank you again for contributing to n8n.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

community Authored by a community member in linear Issue or PR has been created in Linear for internal review node/improvement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@pemontto